Apply UnnecessarySemicolonInEnumeration Checkstyle module #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkinsona
reviewed
Mar 27, 2024
| @@ -113,6 +113,7 @@ | |||
| <module name="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck" /> | |||
| <module name="com.puppycrawl.tools.checkstyle.checks.ArrayTypeStyleCheck" /> | |||
| <module name="com.puppycrawl.tools.checkstyle.checks.OuterTypeFilenameCheck" /> | |||
| <module name="UnnecessarySemicolonInEnumeration"/> | |||
There was a problem hiding this comment.
Note for when we merge this: for consistency, the name should be fully-qualified:
com.puppycrawl.tools.checkstyle.checks.coding.UnnecessarySemicolonInEnumerationCheck
There was a problem hiding this comment.
@wilkinsona Thanks! I updated it as you suggested.
izeye
force-pushed
the
UnnecessarySemicolonInEnumeration
branch
from
723779f
to
a62f004
Compare
This commit also applies it to this project itself and fixes its violations.
izeye
force-pushed
the
UnnecessarySemicolonInEnumeration
branch
from
a62f004
to
a52923f
Compare
wilkinsona
pushed a commit
that referenced
this pull request
Mar 28, 2024
This commit also applies it to this project itself and fixes its violations. See gh-408
wilkinsona
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the
UnnecessarySemicolonInEnumerationCheckstyle module.This PR also applies it to this project itself and fixes its violations.
See spring-projects/spring-framework#32514 and spring-projects/spring-boot@9cdd0c3